Pylint and RTD update patch, adding typing, and other fixes #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattni
approved these changes
Nov 11, 2021
kattni
reviewed
Nov 11, 2021
| @@ -5,3 +5,4 @@ | |||
|
|
|||
| Adafruit-Blinka | |||
| adafruit-circuitpython-hid | |||
| sphinx>=4.0.0 | |||
There was a problem hiding this comment.
This needs to go into a new /docs/requirements.txt file, not in the /requirements.txt file. Please create the new file, add this to it, and remove it from here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to applying the aforementioned patches, I added typing despite there not being an issue for it because it was easy enough and straightforward. Let me know if I should remove that bit.